Fix #6247: Heal selection errors by fully defining qualifier type #6257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves a situation where we cannot find a member `m` of a qualifier of type `T` where `T` is a type variable with lower bound `L`, where `m` is a member of `L`. This has come up occasionally before, but never until now in minimized form. The solution is to instantiate the type variable using `fullyDefinedType` and try again.
smarter
requested changes
Apr 14, 2019
| val x1: String|Null = null | ||
| x1.nn.length | ||
| val x2: String = x1.nn | ||
| x1.nn.length |
There was a problem hiding this comment.
This line failed while the identical expression two lines above succeeded, so something fishy is going on, I've got what I think is a proper fix in #6301.
There was a problem hiding this comment.
Great! But I think it would be still an improvement to have the changes in this PR also. It is insurance against the fact that we are more lazy instantiating type variables than scalac. Do you agree?
There was a problem hiding this comment.
I agree. I just went through all the inference related // dotty deviation comments in the compiler codebase and could remove them all without this fix. Except one which was related to us dropping weak conformance. So let's leave things as they are.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves a situation where we cannot find a member
mof a qualifier of typeTwhere
Tis a type variable with lower boundL, wheremis a member ofL.This has come up occasionally before, but never until now in minimized form. The
solution is to instantiate the type variable using
fullyDefinedTypeand try again.